spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP] Remove unused initialInputBufferOffset a...
Date Sun, 04 Oct 2015 03:29:55 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8973#discussion_r41094076
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
    @@ -186,77 +182,71 @@ class TungstenAggregationIterator(
           // Partial-only
           case (Some(Partial), None) =>
             val updateExpressions = allAggregateFunctions.flatMap(_.updateExpressions)
    -        val algebraicUpdateProjection =
    +        val updateProjection =
               newMutableProjection(updateExpressions, aggregationBufferAttributes ++ inputAttributes)()
     
             (currentBuffer: UnsafeRow, row: InternalRow) => {
    -          algebraicUpdateProjection.target(currentBuffer)
    -          algebraicUpdateProjection(joinedRow(currentBuffer, row))
    +          updateProjection.target(currentBuffer)
    --- End diff --
    
    For _now_, TungstenAggregationIterator only supports expression-based aggregates, and
thus we don't need to explicitly qualify that this is an expression-based update projection.
When I refactor TungstenAggregationIterator to support interpreted aggregates as well, I'll
re-name to disambiguate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message