spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10900][Streaming]Add output operation e...
Date Fri, 02 Oct 2015 22:38:51 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8958#discussion_r41075408
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListener.scala
---
    @@ -39,6 +39,17 @@ case class StreamingListenerBatchCompleted(batchInfo: BatchInfo) extends
Streami
     case class StreamingListenerBatchStarted(batchInfo: BatchInfo) extends StreamingListenerEvent
     
     @DeveloperApi
    +case class StreamingListenerOutputOperationStarted(
    +    outputOperationId: Int,
    +    outputOperationCallSite: String,
    +    startTime: Long) extends StreamingListenerEvent
    +
    +@DeveloperApi
    +case class StreamingListenerOutputOperationCompleted(
    --- End diff --
    
    I think its better for future API compatibility to have another class called `OutputOperationInfo`
(similar to `BatchInfo`). We can add more field in `OutputOperationInfo` later, without breaking
binary compatibility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message