Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: davies <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-8674-spark@git.apache.org>
In-Reply-To: <git-pr-8674-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-10522] [SQL] Nanoseconds of
 Timestamp i...
Content-Type: text/plain
Message-Id: <20150909230147.BB9CCE095F@git1-us-west.apache.org>
Date: Wed,  9 Sep 2015 23:01:47 +0000 (UTC)

Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8674#discussion_r39107802
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ---
    @@ -192,11 +193,10 @@ object DateTimeUtils {
        * Returns Julian day and nanoseconds in a day from the number of microseconds
        */
       def toJulianDay(us: SQLTimestamp): (Int, Long) = {
    -    val seconds = us / MICROS_PER_SECOND
    -    val day = seconds / SECONDS_PER_DAY + JULIAN_DAY_OF_EPOCH
    -    val secondsInDay = seconds % SECONDS_PER_DAY
    -    val nanos = (us % MICROS_PER_SECOND) * 1000L
    -    (day.toInt, secondsInDay * NANOS_PER_SECOND + nanos)
    +    val julian_us = us + JULIAN_DAY_OF_EPOCH * MICROS_PER_DAY
    --- End diff --
    
    If we throw an exception, the job will crash if there are some garbage rows in it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org