Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 471EB1760F for ; Thu, 3 Sep 2015 17:54:08 +0000 (UTC) Received: (qmail 29948 invoked by uid 500); 3 Sep 2015 17:54:08 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 29923 invoked by uid 500); 3 Sep 2015 17:54:08 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 29912 invoked by uid 99); 3 Sep 2015 17:54:07 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2015 17:54:07 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C9110E7E7E; Thu, 3 Sep 2015 17:54:07 +0000 (UTC) From: andrewor14 To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-10431][ Spark Core ] Fix intermittent t... Content-Type: text/plain Message-Id: <20150903175407.C9110E7E7E@git1-us-west.apache.org> Date: Thu, 3 Sep 2015 17:54:07 +0000 (UTC) Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8582#issuecomment-137527589 Yup, LGTM. In the specific test you reported in the JIRA we ran a job before calling `runAndReturnMetrics`, so it makes sense to ensure the queue is empty before running the thing we actually care about. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org