spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10412][SQL] report memory usage for tun...
Date Tue, 29 Sep 2015 19:05:56 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8931#discussion_r40714472
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
    @@ -232,10 +234,12 @@ class SQLMetricsSuite extends SparkFunSuite with SharedSQLContext
{
           testSparkPlanMetrics(df2, 1, Map(
             2L -> ("TungstenAggregate", Map(
               "number of input rows" -> 6L,
    -          "number of output rows" -> 4L)),
    +          "number of output rows" -> 4L,
    +          "number of bytes used" -> 17305600L)),
             0L -> ("TungstenAggregate", Map(
               "number of input rows" -> 4L,
    -          "number of output rows" -> 3L)))
    +          "number of output rows" -> 3L,
    +          "number of bytes used" -> 25958400L)))
    --- End diff --
    
    Note that I just hard-code the right answer in the test, will add comments or use formula
to make it clear why this answer is correct later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message