spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9841][ML] Make set and clear public
Date Fri, 25 Sep 2015 00:24:54 GMT
Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8619#discussion_r40389519
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
    @@ -418,21 +418,21 @@ trait Params extends Identifiable with Serializable {
       /**
        * Sets a parameter in the embedded param map.
        */
    -  protected final def set[T](param: Param[T], value: T): this.type = {
    --- End diff --
    
    The one that I could think of is if someone was trying to interact with the object based
on which params it had this might be easier, but thats probably not enough of a reason. I
can make this protected and just leave clear public if that sounds good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message