spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <>
Subject [GitHub] spark pull request: [SPARK-10692][Streaming]Expose failureReasons ...
Date Wed, 23 Sep 2015 08:40:23 GMT
Github user tdas commented on a diff in the pull request:
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/BatchInfo.scala
    @@ -36,8 +38,8 @@ case class BatchInfo(
         streamIdToInputInfo: Map[Int, StreamInputInfo],
         submissionTime: Long,
         processingStartTime: Option[Long],
    -    processingEndTime: Option[Long]
    -  ) {
    +    processingEndTime: Option[Long],
    +    private[streaming] val failureReasons: Map[Int, String] = Map.empty) {
    --- End diff --
    Wouldnt having another parameter in the constructor break binary compatibility, even if
optional? I am scared of Scala doing crazy stuff. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message