spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rotationsymmetry <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10686] [ML] Add quantilesCol to AFTSurv...
Date Tue, 22 Sep 2015 06:47:07 GMT
Github user rotationsymmetry commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8836#discussion_r40056721
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/AFTSurvivalRegression.scala
---
    @@ -90,6 +108,12 @@ private[regression] trait AFTSurvivalRegressionParams extends Params
           SchemaUtils.checkColumnType(schema, $(censorCol), DoubleType)
           SchemaUtils.checkColumnType(schema, $(labelCol), DoubleType)
         }
    +    if (hasQuantileProbabilities && hasQuantilesCol) {
    +      SchemaUtils.appendColumn(schema, $(quantilesCol), new VectorUDT)
    +    } else if (hasQuantileProbabilities || hasQuantilesCol) {
    +      logWarning("The output will not include quantiles column. " +
    +        "If you want to include, please set both quantileProbabilities and quantilesCol.")
    +    }
    --- End diff --
    
    I think the sematic is clear to me. On the other hand, can we consider these two as a
combo, i.e. 
    case class QuantileParams(quantileProbabilities: Array[Double], quantilesCol: String)
    Then the user will have to set both items simultaneously.
    
    Not sure it will work but try to brain storm. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message