spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...
Date Mon, 21 Sep 2015 20:09:56 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7753#discussion_r40019223
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -229,9 +228,11 @@ private[spark] object JsonProtocol {
       def executorMetricsUpdateToJson(metricsUpdate: SparkListenerExecutorMetricsUpdate):
JValue = {
         val execId = metricsUpdate.execId
         val taskMetrics = metricsUpdate.taskMetrics
    +    val executorMetrics = metricsUpdate.executorMetrics
         ("Event" -> Utils.getFormattedClassName(metricsUpdate)) ~
         ("Executor ID" -> execId) ~
    -    ("Metrics Updated" -> taskMetrics.map { case (taskId, stageId, stageAttemptId,
metrics) =>
    +    ("Executor Metrics Updated" -> executorMetricsToJson(executorMetrics)) ~
    +    ("Task Metrics Updated" -> taskMetrics.map { case (taskId, stageId, stageAttemptId,
metrics) =>
    --- End diff --
    
    unfortunately we can't change the name b/c of the compatibility guarantees we want: (https://github.com/apache/spark/blob/ba882db6f43dd2bc05675133158e4664ed07030a/core/src/main/scala/org/apache/spark/util/JsonProtocol.scala#L39).
 I think we're stuck w/ "Metrics Updated" for tasks, and "Executor Metrics Updated" for the
other metrics.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message