spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10686] [ML] Add quantilesCol to AFTSurv...
Date Mon, 21 Sep 2015 17:02:17 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8836#discussion_r39995988
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/AFTSurvivalRegression.scala
---
    @@ -90,6 +108,9 @@ private[regression] trait AFTSurvivalRegressionParams extends Params
           SchemaUtils.checkColumnType(schema, $(censorCol), DoubleType)
           SchemaUtils.checkColumnType(schema, $(labelCol), DoubleType)
         }
    +    if (hasQuantileProbabilities) {
    --- End diff --
    
    `hasQuantilesCol && hasQuantileProbabilities`? If only one is set, I think we
should make a warn log message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message