spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From travishegner <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10648] Proposed bug fix when oracle ret...
Date Fri, 18 Sep 2015 14:14:27 GMT
Github user travishegner commented on the pull request:

    https://github.com/apache/spark/pull/8780#issuecomment-141462484
  
    That is exactly what I was afraid of. Would the patch make more sense to *only* check
precision for a zero value? Does it ever make sense to have a precision of zero (or less than
zero for that matter)? Could we safely enforce defaults if precision is zero (or less) regardless
of scale? That would solve my problem still, hopefully without compromising functionality
for everyone else.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message