spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6028][Core]A new RPC implemetation base...
Date Thu, 17 Sep 2015 02:16:40 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6457#discussion_r39706302
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Inbox.scala ---
    @@ -0,0 +1,229 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.rpc.netty
    +
    +import java.util.LinkedList
    +import javax.annotation.concurrent.GuardedBy
    +
    +import scala.util.control.NonFatal
    +
    +import org.apache.spark.{Logging, SparkException}
    +import org.apache.spark.rpc.{RpcAddress, RpcEndpoint, ThreadSafeRpcEndpoint}
    +
    +private[netty] sealed trait InboxMessage
    +
    +private[netty] case class ContentMessage(
    +    senderAddress: RpcAddress,
    +    content: Any,
    +    needReply: Boolean,
    +    context: NettyRpcCallContext) extends InboxMessage
    +
    +/**
    + * A message type that will be posted to all registered [[RpcEndpoint]]
    + */
    +private[netty] sealed trait BroadcastMessage extends InboxMessage
    +
    +private[netty] case object OnStart extends InboxMessage
    +
    +private[netty] case object OnStop extends InboxMessage
    +
    +private[netty] case class Associated(remoteAddress: RpcAddress) extends BroadcastMessage
    +
    +/**
    + * A broadcast message that indicates
    + */
    +private[netty] case class Disassociated(remoteAddress: RpcAddress) extends BroadcastMessage
    +
    +/**
    + * A broadcast message that indicates a network error
    + */
    +private[netty] case class AssociationError(cause: Throwable, remoteAddress: RpcAddress)
    +  extends BroadcastMessage
    +
    +/**
    + * A inbox that stores messages for an [[RpcEndpoint]] and posts messages to it thread-safely.
    + * @param endpointRef
    + * @param endpoint
    + */
    +private[netty] class Inbox(
    +    val endpointRef: NettyRpcEndpointRef,
    +    val endpoint: RpcEndpoint) extends Logging {
    +
    +  private val supportConcurrent = !endpoint.isInstanceOf[ThreadSafeRpcEndpoint]
    +
    +  @GuardedBy("this")
    +  protected val messages = new LinkedList[InboxMessage]()
    +
    +  @GuardedBy("this")
    +  private var stopped = false
    +
    +  @GuardedBy("this")
    +  private var enableConcurrent = false
    +
    +  @GuardedBy("this")
    +  private var workerCount = 0
    +
    +  // OnStart should be the first message to process
    +  synchronized {
    +    messages.add(OnStart)
    +  }
    +
    +  def process(dispatcher: Dispatcher): Boolean = {
    --- End diff --
    
    Can you add scaladoc describing at least the return value?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message