spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <>
Subject [GitHub] spark pull request: SPARK-1537 publisher-side code and tests
Date Tue, 15 Sep 2015 23:03:42 GMT
Github user vanzin commented on a diff in the pull request:
    --- Diff: yarn/history/src/main/scala/org/apache/spark/deploy/history/yarn/YarnEventListener.scala
    @@ -0,0 +1,142 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.history.yarn
    +import org.apache.spark.scheduler._
    +import org.apache.spark.util.{SystemClock, Clock}
    +import org.apache.spark.{Logging, SparkContext}
    + * Spark listener which queues up all received events to the [[YarnHistoryService]] passed
    + * as a constructor. There's no attempt to filter event types at this point.
    + * @param sc context
    --- End diff --
    nit: I believe the convention is to have an empty line before these.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message