spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <>
Subject [GitHub] spark pull request: [Spark-9769][ML][PY] add python api for countv...
Date Tue, 15 Sep 2015 22:39:24 GMT
Github user holdenk commented on a diff in the pull request:
    --- Diff: python/pyspark/sql/ ---
    @@ -830,12 +830,12 @@ def test_infer_long_type(self):
             self.assertEquals(100000000000000, df1.first().f2)
             self.assertEqual(_infer_type(1), LongType())
    -        self.assertEqual(_infer_type(2**10), LongType())
    -        self.assertEqual(_infer_type(2**20), LongType())
    -        self.assertEqual(_infer_type(2**31 - 1), LongType())
    -        self.assertEqual(_infer_type(2**31), LongType())
    -        self.assertEqual(_infer_type(2**61), LongType())
    -        self.assertEqual(_infer_type(2**71), LongType())
    +        self.assertEqual(_infer_type(1<<10), LongType())
    --- End diff --
    Ah sorry, I though the earlier comment was to update the 2** to 1<< everywhere in
pyspark (since there were not a lot of places.) I'll revert this change.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message