spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-10611 Clone Configuration for each task ...
Date Tue, 15 Sep 2015 19:03:50 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8763#discussion_r39551271
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala ---
    @@ -230,12 +251,16 @@ class NewHadoopRDD[K, V](
         super.persist(storageLevel)
       }
     
    -
    -  def getConf: Configuration = confBroadcast.value.value
    --- End diff --
    
    This old `getConf` used to be public, but now it's protected. The old `getConf` used to
always return the same object, whereas the new `getConf` will return different Configuration
instances on back-to-back calls. I don't know enough about how developers use NewHadoopRDD
directly to be able to say whether this would be a problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message