spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [DOCS] Small fixes to Spark on Yarn doc
Date Tue, 15 Sep 2015 14:43:23 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8762#discussion_r39518473
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -54,8 +54,8 @@ In `yarn-cluster` mode, the driver runs on a different machine than
the client,
     
     # Preparations
     
    -Running Spark-on-YARN requires a binary distribution of Spark which is built with YARN
support.
    -Binary distributions can be downloaded from the Spark project website. 
    +Running Spark on YARN requires a binary distribution of Spark which is built with YARN
support.
    --- End diff --
    
    I see, it renders in code font already just not in the code box format. OK that seems
fine. I think it's OK to merge this.
    
    I'm referring to piecemeal edits since you've made a number of tiny PRs without a JIRA.
It would be more efficient to have a review of whole logical sections of docs, and focus on
small but not trivial changes in one PR. You'll probably end up spotting some broader opportunities
to make docs consistent. Yes several of these changes here end up being good small fixes.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message