spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...
Date Mon, 14 Sep 2015 19:24:44 GMT
Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/7884#issuecomment-140182561
  
    Can you please update the Scala doc to clarify:
    * ```count``` ignores instance weights
    * Add warning in training summary that it ignores the training weights currently (except
for the objective trace).
    
    Other than those small items, this looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message