spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From saucam <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7142][SQL]: Minor enhancement to Boolea...
Date Fri, 11 Sep 2015 09:53:17 GMT
Github user saucam commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5700#discussion_r39256778
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
    @@ -413,6 +418,10 @@ object BooleanSimplification extends Rule[LogicalPlan] with PredicateHelper
{
             case LessThan(l, r) => GreaterThanOrEqual(l, r)
             // not(l <= r)  =>  l > r
             case LessThanOrEqual(l, r) => GreaterThan(l, r)
    +        // not(l || r) => not(l) && not(r)
    +        case Or(l, r) => And(Not(l), Not(r))
    +        // not(l && r) => not(l) or not(r)
    +        case And(l, r) => Or(Not(l), Not(r))
    --- End diff --
    
    @cloud-fan could you please explain a bit more when and how converting to "And" may not
be an optimization ? I was wondering would it actually result in any kind of performance hit
? Also could you tell how #8200 is more reasonable ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message