spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wulei-bj-cn <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10149] [CORE] [WIP] Locality Level is a...
Date Tue, 08 Sep 2015 09:02:16 GMT
Github user wulei-bj-cn commented on the pull request:

    https://github.com/apache/spark/pull/8533#issuecomment-138486424
  
    @CodingCat Thanks so much for your suggestion! It does sound fair/smart to make the patch
as cleaner as possible. As you suggested, I moved the fixes into TaskLocation.scala, and removed
all the changes I made in TaskSetManager.scala, would you plz help take a look at the changes
? See if you've got more comments on it. 
    
    BTW, the patch passed Spark/Scala style check, and I run a build with this patch on a
4-node cluster, results are good and expected. That is, no matter SPARK_LOCAL_HOSTNAME is
set or not, we always get locality level as 'NODE_LOCAL' for HadoopRDDs. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message