spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10419] [SQL] Adding SQLServer support f...
Date Sat, 05 Sep 2015 09:33:50 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8575#discussion_r38809227
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
    @@ -240,3 +242,21 @@ case object DB2Dialect extends JdbcDialect {
         case _ => None
       }
     }
    +
    +/**
    + * :: DeveloperApi ::
    + * Default SQL Server dialect, mapping the datetimeoffset types to a String on read.
    + */
    +@DeveloperApi
    +case object SqlServerDialect extends JdbcDialect {
    +
    +  override def canHandle(url: String): Boolean = url.startsWith("jdbc:sqlserver")
    +
    +  override def getCatalystType(
    +    sqlType: Int, typeName: String, size: Int, md: MetadataBuilder): Option[DataType]
= {
    +        if (typeName.contains("datetimeoffset")) {
    --- End diff --
    
    indentation is off here. take a look at rest of this file to see how they should be indented.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message