spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9516][UI] Improvement of Thread Dump Pa...
Date Wed, 02 Sep 2015 18:49:47 GMT
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/7910#issuecomment-137207794
  
     I would strongly prefer to do the grep in the browser; all of the data that we're filtering
is present there anyways and it will lead to better UX because it can support features like
"search as you type."
    
    In addition, the UX semantics of a grep that requires a roundtirp to Scala are a bit different:
in that case, each grep call is obtaining and searching a _different_ thread dump, whereas
I imagine that most users want to search within the _same_ threadump with different queries.
(Apologizes if I've misunderstood the current behavior).
    
    Also: is regex support really what users want / expect here? We should think through actual
use-cases carefully before spending a bunch of time building a tool that's helpful to a handful
of power users but which offers less utility for an average user.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message