spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...
Date Wed, 02 Sep 2015 02:53:18 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8007#discussion_r38494982
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -362,8 +362,9 @@ private[spark] object JsonProtocol {
             ("Stack Trace" -> stackTrace) ~
             ("Full Stack Trace" -> exceptionFailure.fullStackTrace) ~
             ("Metrics" -> metrics)
    -      case ExecutorLostFailure(executorId) =>
    -        ("Executor ID" -> executorId)
    +      case ExecutorLostFailure(executorId, isNormalExit) =>
    +        ("Executor ID" -> executorId) ~
    +        ("Is exit reason normal" -> isNormalExit)
    --- End diff --
    
    Instead of this key I'd use something like `"Normal Exit"`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message