spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From feynmanliang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9654][ML][PYSPARK] Add IndexToString to...
Date Tue, 01 Sep 2015 06:38:54 GMT
Github user feynmanliang commented on the pull request:

    https://github.com/apache/spark/pull/7976#issuecomment-136600743
  
    There's still a "." on L952.
    
    I agree my wording is not the clearest, do you have any thoughts about improving it? In
any case, I think this issue is quite small and I'm fine leaving it as. I just thought it
was weird to use "is supplied" on one line and "the empty array is ignored" in another as
if they were two different things; is it reasonable to expect new users to assume that not
passing in any params leads to `labels = []`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message