spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9946] fix NPE and thread-safety in Task...
Date Thu, 13 Aug 2015 21:52:14 GMT
GitHub user davies opened a pull request:

    https://github.com/apache/spark/pull/8177

    [SPARK-9946] fix NPE and thread-safety in TaskMemoryManager

    Currently, we access the `page.pageNumer` after it's freed, that could be modified by
other thread, cause NPE.
    
    The same TaskMemoryManager could be used by multiple threads (for example, Python UDF
and TransportScript), so it should be thread safe to allocate/free memory/page. The underlying
Bitset and HashSet are not thread safe, we should put them inside a synchronized block.
    
    cc @JoshRosen 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davies/spark memory_manager

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/8177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8177
    
----
commit 4e801edc223ac096689d5e3c76646ea37af5fef1
Author: Davies Liu <davies@databricks.com>
Date:   2015-08-13T21:46:18Z

    fix bug and thread-safety in TaskMemoryManager

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message