spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9753] [SQL] TungstenAggregate should al...
Date Fri, 07 Aug 2015 21:45:56 GMT
GitHub user yhuai opened a pull request:

    https://github.com/apache/spark/pull/8041

    [SPARK-9753] [SQL] TungstenAggregate should also accept InternalRow instead of just UnsafeRow

    https://issues.apache.org/jira/browse/SPARK-9753
    
    This PR makes TungstenAggregate to accept `InternalRow` instead of just `UnsafeRow`. Also,
it adds an `getAggregationBufferFromUnsafeRow` method to `UnsafeFixedWidthAggregationMap`.
It is useful when we already have grouping keys stored in `UnsafeRow`s. Finally, it wraps
`InputStream` and `OutputStream` in `UnsafeRowSerializer` with `BufferedInputStream` and `BufferedOutputStream`,
respectively.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yhuai/spark joinedRowForProjection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/8041.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8041
    
----
commit e93c009a62a4666a36aacec9fdd735f9a5a40835
Author: Yin Huai <yhuai@databricks.com>
Date:   2015-08-07T02:26:26Z

    Add getAggregationBufferFromUnsafeRow for cases that the given groupingKeyRow is already
an UnsafeRow.

commit d68b74e1a8197824dbb7454b1e9ca992bd4b8187
Author: Yin Huai <yhuai@databricks.com>
Date:   2015-08-07T02:26:50Z

    Use joinedRow instead of UnsafeRowJoiner.

commit 7753e343bc29a7d110c95c80b70ecccffb0dd6a0
Author: Yin Huai <yhuai@databricks.com>
Date:   2015-08-07T21:43:07Z

    Use BufferedInputStream and BufferedOutputStream.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message