spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9546][SQL] Centralize orderable data ty...
Date Sun, 02 Aug 2015 23:42:47 GMT
GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/7880

    [SPARK-9546][SQL] Centralize orderable data type checking.

    This pull request creates two isOrderable functions in RowOrdering that can be used to
check whether a data type or a sequence of expressions can be used in sorting.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-9546

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/7880.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7880
    
----
commit 3922b544054b8ef1f10147e86d690e15526ede29
Author: Liang-Chi Hsieh <viirya@gmail.com>
Date:   2015-05-30T13:41:56Z

    Support ordering on named_struct.

commit b6e10092cc4215a01f0378435a7622d014e1fd35
Author: Liang-Chi Hsieh <viirya@gmail.com>
Date:   2015-05-30T16:53:09Z

    Fix scala style.

commit f651b8dbfbd6b6c0cf67cd405ce472a0d5f6d2f7
Author: Liang-Chi Hsieh <viirya@gmail.com>
Date:   2015-06-01T15:29:03Z

    Remove Either and move orderings to BinaryComparison to reuse it.

commit cf58dc369a417240b60d50a1728413c195db7cbc
Author: Liang-Chi Hsieh <viirya@gmail.com>
Date:   2015-06-01T15:32:50Z

    Use checkAnswer.

commit 3c142e406e7b7461334113d57e6f9e00a1988422
Author: Liang-Chi Hsieh <viirya@gmail.com>
Date:   2015-06-01T15:48:44Z

    Fix scala style.

commit 20716936db429f8fc793b65ff70fd841c8c6d428
Author: Liang-Chi Hsieh <viirya@gmail.com>
Date:   2015-06-04T06:50:12Z

    Merge remote-tracking branch 'upstream/master' into compare_named_struct
    
    Conflicts:
    	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala

commit 94b27d5dcb73bffa4a03d6cb2ec082084be17190
Author: Liang-Chi Hsieh <viirya@gmail.com>
Date:   2015-06-04T07:44:27Z

    Remove test for error on complex type comparison.

commit 8f4d775ae69c81b4e56aca1eb8c1d7aa87422e5b
Author: Liang-Chi Hsieh <viirya@appier.com>
Date:   2015-07-28T15:33:32Z

    Merge remote-tracking branch 'upstream/master' into compare_named_struct
    
    Conflicts:
    	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
    	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
    	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala
    	sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala

commit 9d67f686b3b06459708b6b0d31d49aa81e55b381
Author: Liang-Chi Hsieh <viirya@appier.com>
Date:   2015-07-28T15:39:35Z

    Fix wrongly merging.

commit 1187a65d0173669abc39be5c2e016346c5ed36d4
Author: Liang-Chi Hsieh <viirya@appier.com>
Date:   2015-07-28T15:54:38Z

    Fix scala style.

commit f8b2e9c3c974309a8fbf394e9c796359b3731f91
Author: Liang-Chi Hsieh <viirya@appier.com>
Date:   2015-07-29T09:50:49Z

    Merge remote-tracking branch 'upstream/master' into compare_named_struct

commit 1f661966103ff01b7997cf43f95d5be2b32473d2
Author: Liang-Chi Hsieh <viirya@appier.com>
Date:   2015-07-29T10:20:08Z

    Reuse RowOrdering and GenerateOrdering.

commit 43d435405ba40d2727eddd6d74739304427c00cb
Author: Liang-Chi Hsieh <viirya@appier.com>
Date:   2015-07-31T03:40:09Z

    Merge remote-tracking branch 'upstream/master' into compare_named_struct
    
    Conflicts:
    	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala

commit d5349c706876c4a17df89d5275102b54216bda27
Author: Liang-Chi Hsieh <viirya@appier.com>
Date:   2015-07-31T08:26:34Z

    Merge remote-tracking branch 'upstream/master' into compare_named_struct

commit dae6aadba7e87e0c24919958df664268f962ae69
Author: Liang-Chi Hsieh <viirya@appier.com>
Date:   2015-07-31T08:30:08Z

    Fix nested struct.

commit 3a3f40e05f2049069173da8eb628968ff1341d71
Author: Liang-Chi Hsieh <viirya@appier.com>
Date:   2015-07-31T08:40:51Z

    Don't need to add compare to InternalRow because we can use RowOrdering.

commit d2ba8adcf5057b6d216badd855c899b701d6282f
Author: Liang-Chi Hsieh <viirya@appier.com>
Date:   2015-07-31T08:51:32Z

    Remove unused import.

commit 2537813aaef756b97e0ca5fa0af793a1756e1be3
Author: Reynold Xin <rxin@databricks.com>
Date:   2015-08-02T22:13:07Z

    Merge branch 'compare_named_struct' of github.com:viirya/spark-1 into sort-struct
    
    Conflicts:
    	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala

commit 4968231782499b494c02cf60c7f95dddb673f7c3
Author: Reynold Xin <rxin@databricks.com>
Date:   2015-08-02T22:25:57Z

    Minor fixes.

commit 28502f528c04f556671cc2a0186968d2692f5cdb
Author: Reynold Xin <rxin@databricks.com>
Date:   2015-08-02T23:41:37Z

    [SPARK-9546][SQL] Centralize orderable data type checking.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message