spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10101] [SQL] Added stringDataType optio...
Date Mon, 31 Aug 2015 23:26:40 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8374#discussion_r38371761
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
    @@ -161,13 +161,15 @@ object JdbcUtils extends Logging {
       /**
        * Compute the schema string for this RDD.
        */
    -  def schemaString(df: DataFrame, url: String): String = {
    +  def schemaString(
    +                    df: DataFrame,
    +                    url: String): String = {
    --- End diff --
    
    This doesn't need to change (and is not indented incorrectly).
    https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide#SparkCodeStyleGuide-Indentation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message