spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From feynmanliang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10023] [ML] [PySpark] Unified DecisionT...
Date Mon, 31 Aug 2015 22:02:43 GMT
Github user feynmanliang commented on the pull request:

    https://github.com/apache/spark/pull/8528#issuecomment-136513283
  
    To enable checkpointing you also need to set the `cacheNodeIds` param so that should be
modified as well.
    
    I think we need to have some more discussion about whether this change is appropriate.
I think the rationale for not including in `sharedParams` was to hide the `expertParam`s.
It's also important to note that the semantics behind decision tree's `setCheckpointInterval`
differs from the current usage of `HasCheckpointInterval` in `ALS` since it depends on `cacheNodeIds`.
    
    CC @jkbradley 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message