spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From feynmanliang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4980] [MLlib] Add decay factors to stre...
Date Thu, 27 Aug 2015 21:43:43 GMT
Github user feynmanliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8022#discussion_r38149963
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala
---
    @@ -0,0 +1,116 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.mllib.regression
    +
    +import org.apache.spark.Logging
    +import org.apache.spark.annotation.Experimental
    +
    +/**
    + * :: Experimental ::
    + * Supplies an interface for the discount value in
    + * the forgetful update rule in StreamingLinearAlgorithm.
    + * Actual implementation is provided in StreamingDecaySetter[T].
    + */
    +@Experimental
    +trait StreamingDecay {
    +  /**
    +   * Derive the discount factor.
    +   *
    +   * @param numNewDataPoints number of data points for the RDD arriving at time t.
    +   * @return Discount factor
    +   */
    +  def getDiscount(numNewDataPoints: Long): Double
    +}
    +
    +/**
    + * :: Experimental ::
    + * StreamingDecaySetter provides the concrete implementation
    + * of getDiscount in StreamingDecay and setters for decay factor
    + * and half-life.
    + */
    +@Experimental
    +private[mllib] trait StreamingDecaySetter[T] extends Logging {
    +  self: T =>
    --- End diff --
    
    keep self type annotation on L47


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message