spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From feynmanliang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10260][ML] Add @Since annotation to ml....
Date Wed, 26 Aug 2015 17:26:46 GMT
Github user feynmanliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8455#discussion_r38009649
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala ---
    @@ -84,27 +93,32 @@ private[clustering] trait KMeansParams extends Params with HasMaxIter
with HasFe
      *
      * @param parentModel a model trained by spark.mllib.clustering.KMeans.
      */
    +@Since("1.5.0")
     @Experimental
     class KMeansModel private[ml] (
    -    override val uid: String,
    +    @Since("1.5.0") override val uid: String,
    --- End diff --
    
    No need to annotate params to private constructor


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message