spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10292][SQL][WIP] make metadata query-ab...
Date Wed, 26 Aug 2015 16:00:21 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8461#discussion_r37999952
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
---
    @@ -44,7 +90,20 @@ trait Catalog {
     
       def tableExists(tableIdentifier: Seq[String]): Boolean
     
    -  def lookupRelation(
    +  final def lookupRelation(
    +      tableIdentifier: Seq[String],
    +      alias: Option[String] = None): LogicalPlan = {
    +    val tableIdent = processTableIdentifier(tableIdentifier)
    +    if (tableIdent.length == 1 && tableIdent.head == TABLES_META_NAME) {
    +      LocalRelation(tablesMetaOutput, tablesMeta().map(tablesMetaConverter))
    +    } else if (tableIdent.length == 1 && tableIdent.head == COLUMNS_META_NAME)
{
    +      LocalRelation(columnsMetaOutput, columnsMeta().map(columnsMetaConverter))
    +    } else {
    +      lookupRelationInternal(tableIdentifier, alias)
    +    }
    +  }
    +
    +  protected def lookupRelationInternal(
    --- End diff --
    
    need some refactor here to git rid of this method, I'll try stackable trait later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message