spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...
Date Tue, 25 Aug 2015 04:47:03 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8394#discussion_r37832419
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -945,6 +947,19 @@ setMethod("[", signature(x = "DataFrame", i = "missing"),
                 select(x, j)
               })
     
    +#' @rdname select
    +setMethod("[", signature(x = "DataFrame", i = "Column"),
    +          function(x, i, j, ...) {
    --- End diff --
    
    Are you referring to `...`?
    You are probably right... I'm more or less following line 938 above - since this is a
i-not-missing overload of the operator/method.
    ```
     setMethod("[", signature(x = "DataFrame", i = "missing"),
               function(x, i, j, ...) {
    ```
    
    Perhaps we should take both out? But that might be a breaking change though.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message