spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3247][SQL] An API for adding data sourc...
Date Thu, 20 Aug 2015 10:20:34 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2475#discussion_r37514803
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/filters.scala ---
    @@ -0,0 +1,26 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.sources
    +
    +abstract class Filter
    +
    +case class EqualTo(attribute: String, value: Any) extends Filter
    +case class GreaterThan(attribute: String, value: Any) extends Filter
    +case class GreaterThanOrEqual(attribute: String, value: Any) extends Filter
    +case class LessThan(attribute: String, value: Any) extends Filter
    +case class LessThanOrEqual(attribute: String, value: Any) extends Filter
    --- End diff --
    
    I guess it's because most underlying data sources (like Parquet and ORC) don't support
predicates like `a < b`. JDBC might be the only Spark SQL data source out there that supports
atomic predicates involving more than one attributes?
    
    cc @rxin @marmbrus 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message