spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9899] [SQL] Disables customized output ...
Date Wed, 19 Aug 2015 18:52:11 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8317#discussion_r37452819
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriterContainer.scala
---
    @@ -58,6 +58,9 @@ private[sql] abstract class BaseWriterContainer(
       // This is only used on driver side.
       @transient private val jobContext: JobContext = job
     
    +  private val speculationEnabled: Boolean =
    --- End diff --
    
    why bother having a private variable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message