spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9689][SQL]Fix bug of not invalidate the...
Date Wed, 19 Aug 2015 15:24:37 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8023#discussion_r37427715
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
    @@ -97,13 +106,13 @@ private[sql] class CacheManager(sqlContext: SQLContext) extends Logging
{
           logWarning("Asked to cache already cached data.")
         } else {
           cachedData +=
    -        CachedData(
    +        new CachedData(
               planToCache,
               InMemoryRelation(
                 sqlContext.conf.useCompression,
                 sqlContext.conf.columnBatchSize,
                 storageLevel,
    -            sqlContext.executePlan(query.logicalPlan).executedPlan,
    +            sqlContext.executePlan(planToCache).executedPlan,
    --- End diff --
    
    I don't think we should change this line. For example, an existing Parquet dataset may
be overwritten, and the new dataset has a completely different schema. When this does happen,
the original code can catch the error by performing the analysis phase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message