spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mccheah <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...
Date Tue, 18 Aug 2015 21:35:52 GMT
Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8007#discussion_r37356728
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -207,6 +211,17 @@ private[yarn] class YarnAllocator(
       }
     
       /**
    +   * Gets the executor loss reason for a disconnected executor.
    +   * Note that this method is expected to be called exactly once per executor ID.
    +   */
    +  def getExecutorLossReason(executorId: String): ExecutorLossReason = synchronized {
    +    allocateResources()
    +    // Expect to be asked for a loss reason once and exactly once.
    +    assert(completedExecutorExitReasons.contains(executorId))
    --- End diff --
    
    By the way I'm open to removing this assertion and building up the map without removing
items from it, but I'm not sure of what the memory implications are.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message