spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9952] Fix N^2 loop when DAGScheduler.ge...
Date Mon, 17 Aug 2015 01:27:22 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8178#discussion_r37154006
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -302,12 +302,12 @@ class DAGScheduler(
           shuffleDep: ShuffleDependency[_, _, _],
           firstJobId: Int): ShuffleMapStage = {
         val rdd = shuffleDep.rdd
    -    val numTasks = rdd.partitions.size
    +    val numTasks = rdd.partitions.length
    --- End diff --
    
    super nit, but any reason for all the `size` -> `length` changes?  just seems like
a bit of noise if we ever look in git history for these lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message