spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9984][SQL] Create local physical operat...
Date Sat, 15 Aug 2015 18:32:53 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8212#discussion_r37138039
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/local/LocalNode.scala
---
    @@ -0,0 +1,86 @@
    +/*
    +* Licensed to the Apache Software Foundation (ASF) under one or more
    +* contributor license agreements.  See the NOTICE file distributed with
    +* this work for additional information regarding copyright ownership.
    +* The ASF licenses this file to You under the Apache License, Version 2.0
    +* (the "License"); you may not use this file except in compliance with
    +* the License.  You may obtain a copy of the License at
    +*
    +*    http://www.apache.org/licenses/LICENSE-2.0
    +*
    +* Unless required by applicable law or agreed to in writing, software
    +* distributed under the License is distributed on an "AS IS" BASIS,
    +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +* See the License for the specific language governing permissions and
    +* limitations under the License.
    +*/
    +
    +package org.apache.spark.sql.execution.local
    +
    +import org.apache.spark.sql.Row
    +import org.apache.spark.sql.catalyst.{CatalystTypeConverters, InternalRow}
    +import org.apache.spark.sql.catalyst.expressions.Attribute
    +import org.apache.spark.sql.catalyst.trees.TreeNode
    +import org.apache.spark.sql.types.StructType
    +
    +/**
    + * A local physical operator, in the form of an iterator.
    + *
    + * Before consuming the iterator, open function must be called.
    + * After consuming the iterator, close function must be called.
    + */
    +abstract class LocalNode extends TreeNode[LocalNode] {
    --- End diff --
    
    We might not need to reuse the local operators -- since we can make a copy of them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message