spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9922] [ML] rename StringIndexerReverse ...
Date Thu, 13 Aug 2015 04:44:12 GMT
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/8152#issuecomment-130533800
  
    I think both could work -- looking at this in isolation, I have a slight preference for
the shorter one. However, I think the most important thing here is to be consistent with other
parts of MLlib. If everywhere else is using setInput/Output, it'd make more sense to follow
that.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message