spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <>
Subject [GitHub] spark pull request: [SPARK-9795] Dynamic allocation: avoid double ...
Date Tue, 11 Aug 2015 17:45:24 GMT
Github user andrewor14 commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
    @@ -422,16 +422,19 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl,
val rpcEnv: Rp
           logWarning(s"Executor to kill $id does not exist!")
    +    // If an executor is already pending to be removed, do not kill it again (SPARK-9795)
    +    val executorsToKill = knownExecutors.filter { id => !executorsPendingToRemove.contains(id)
    --- End diff --
    That looks fine, but in this patch I wanted to limit the scope of the changes so I'm going
to leave this as is.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message