spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mindprince <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9724] [WEB UI] Avoid unnecessary redire...
Date Tue, 11 Aug 2015 01:14:11 GMT
Github user mindprince commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8014#discussion_r36703520
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
    @@ -251,6 +251,13 @@ private[spark] object JettyUtils extends Logging {
       private def attachPrefix(basePath: String, relativePath: String): String = {
         if (basePath == "") relativePath else (basePath + relativePath).stripSuffix("/")
       }
    +
    +  /**
    +   * Attach a prefix to the given path, don't remove the trailing / if present.
    +   */
    +  private def attachPrefixForRedirect(basePath: String, relativePath: String): String
= {
    --- End diff --
    
    @srowen I have inlined the methods and fixed the if condition for calculating `prefixedPath`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message