spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6212][SQL]The EXPLAIN output of CTAS on...
Date Sun, 09 Aug 2015 04:04:23 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7986#discussion_r36584275
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateTableAsSelect.scala
---
    @@ -91,6 +93,6 @@ case class CreateTableAsSelect(
       }
     
       override def argString: String = {
    -    s"[Database:$database, TableName: $tableName, InsertIntoHiveTable]\n" + query.toString
    +    s"[Database:$database, TableName: $tableName, InsertIntoHiveTable]"
    --- End diff --
    
    I think it is fine to add the storage format in the string. But, `tableDesc` itself has
too much information and it is hard to figure out the meaning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message