spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9674][SPARK-9667] Remove SparkSqlSerial...
Date Fri, 07 Aug 2015 18:02:31 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7981#discussion_r36544310
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
    @@ -39,21 +40,34 @@ import org.apache.spark.{HashPartitioner, Partitioner, RangePartitioner,
SparkEn
     @DeveloperApi
     case class Exchange(newPartitioning: Partitioning, child: SparkPlan) extends UnaryNode
{
     
    -  override def outputPartitioning: Partitioning = newPartitioning
    -
    -  override def output: Seq[Attribute] = child.output
    -
    -  override def outputsUnsafeRows: Boolean = child.outputsUnsafeRows
    +  override def nodeName: String = if (tungstenMode) "TungstenExchange" else "Exchange"
     
    -  override def canProcessSafeRows: Boolean = true
    -
    -  override def canProcessUnsafeRows: Boolean = {
    +  /**
    +   * Returns true iff the children outputs aggregate UDTs that are not part of the SQL
type.
    +   * This only happens with the old aggregate implementation and should be removed in
1.6.
    +   */
    +  private lazy val tungstenMode: Boolean = {
    +    val unserializableUDT = child.schema.exists(_.dataType match {
    --- End diff --
    
    That's a good idea. I'm going to merge this one first and submit a patch.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message