spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenghao-intel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9683][SQL] copy UTF8String when convert...
Date Fri, 07 Aug 2015 06:59:33 GMT
Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7990#discussion_r36495089
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/FromUnsafe.scala
---
    @@ -52,6 +53,8 @@ case class FromUnsafe(child: Expression) extends UnaryExpression
           }
           new GenericArrayData(result)
     
    +    case StringType => value.asInstanceOf[UTF8String].clone()
    --- End diff --
    
    Yes, I know, I assume we need to handle the top data type in `StringType` also, otherwise,
it still will cause confusing if people call the `FromUnsafe` to get the `StringType` of data.
    
    I mean we'd better add the `StringType` support in https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala#L159


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message