spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9683][SQL] we should deep copy UTF8Stri...
Date Thu, 06 Aug 2015 18:11:32 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7990#discussion_r36446285
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/RowFormatConvertersSuite.scala
---
    @@ -87,4 +91,36 @@ class RowFormatConvertersSuite extends SparkPlanTest {
           input.map(Row.fromTuple)
         )
       }
    +
    +  test("SPARK-9683: we should deep copy UTF8String when convert unsafe row to safe row")
{
    +    SparkPlan.currentContext.set(TestSQLContext)
    +    val schema = ArrayType(StringType)
    +    val rows = (1 to 100).map { i =>
    +      InternalRow(new GenericArrayData(Array[Any](UTF8String.fromString(i.toString))))
    +    }
    +    val relation = LocalTableScan(Seq(AttributeReference("t", schema)()), rows)
    +
    +    val plan =
    +      DummyPlan(
    +        ConvertToSafe(
    +          ConvertToUnsafe(relation)))
    +    assert(plan.execute().collect().map(_.getUTF8String(0).toString) === (1 to 100).map(_.toString))
    +  }
    +}
    +
    +case class DummyPlan(child: SparkPlan) extends UnaryNode {
    +
    +  override protected def doExecute(): RDD[InternalRow] = {
    +    child.execute().mapPartitions { iter =>
    +      // cache all strings to make sure we have deep copied UTF8String inside incoming
    +      // safe InternalRow.
    +      val strings = new scala.collection.mutable.ArrayBuffer[UTF8String]
    +      iter.foreach { row =>
    +        strings += row.getArray(0).getUTF8String(0)
    --- End diff --
    
    Right now, the rule is that, do the copy when we want to hold something (UTF8String/Row/Array/Map).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message