spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9439] [yarn] External shuffle service s...
Date Thu, 06 Aug 2015 16:38:10 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7839#discussion_r36436044
  
    --- Diff: network/yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
---
    @@ -100,11 +121,34 @@ private boolean isAuthenticationEnabled() {
        */
       @Override
       protected void serviceInit(Configuration conf) {
    +
    +    // In case this NM was killed while there were running spark applications, we need
to restore
    +    // lost state for the existing executors.  We look for an existing file in the NM's
local dirs.
    +    // If we don't find one, then we choose a file to use to save the state next time.
 However, we
    +    // do *not* immediately register all the executors in that file, just in case the
application
    +    // was terminated while the NM was restarting.  We wait until yarn tells the service
about the
    +    // app again via #initializeApplication, so we know it's still running.  That is
important
    +    // for preventing a leak where the app data would stick around *forever*.  This does
leave
    +    // a small race -- if the NM restarts *again*, after only some of the existing apps
have been
    --- End diff --
    
    sorry I had never given a full response to this -- yes I'm now convinced that we can rely
on yarn here, so I'll change this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message