spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9482] [SQL] Fix race condition in Broad...
Date Wed, 05 Aug 2015 18:50:31 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7940#discussion_r36339415
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala
---
    @@ -59,19 +57,17 @@ case class BroadcastHashJoin(
       override def requiredChildDistribution: Seq[Distribution] =
         UnspecifiedDistribution :: UnspecifiedDistribution :: Nil
     
    -  @transient
    -  private val broadcastFuture = future {
    +  private lazy val broadcastedRelation = {
    --- End diff --
    
    I think so, will re-purpose this PR to fix the thead-safy issue about UnsafeProjection.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message