spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8978][Streaming] Implements the DirectK...
Date Tue, 04 Aug 2015 08:52:37 GMT
Github user tdas commented on the pull request:

    https://github.com/apache/spark/pull/7796#issuecomment-127530031
  
    @nraychaudhuri  
    1. I had suggested earlier that there should be one controller per partition. But I realize
that this complicates stuff as there can be only one RateController associated with a InputDStream.

    2. Please update the title to use DirectKafkaRateController
    3. Ideally, we have to add a unit test to see that the rate update is actually used. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message