spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5155] [PySpark] [Streaming] Mqtt stream...
Date Tue, 04 Aug 2015 07:58:51 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7833#discussion_r36165180
  
    --- Diff: external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala
---
    @@ -17,46 +17,30 @@
     
     package org.apache.spark.streaming.mqtt
     
    -import java.net.{URI, ServerSocket}
    -import java.util.concurrent.CountDownLatch
    -import java.util.concurrent.TimeUnit
    -
     import scala.concurrent.duration._
     import scala.language.postfixOps
     
    -import org.apache.activemq.broker.{TransportConnector, BrokerService}
    -import org.apache.commons.lang3.RandomUtils
    -import org.eclipse.paho.client.mqttv3._
    -import org.eclipse.paho.client.mqttv3.persist.MqttDefaultFilePersistence
    -
     import org.scalatest.BeforeAndAfter
     import org.scalatest.concurrent.Eventually
     
    -import org.apache.spark.streaming.{Milliseconds, StreamingContext}
    -import org.apache.spark.storage.StorageLevel
    -import org.apache.spark.streaming.dstream.ReceiverInputDStream
    -import org.apache.spark.streaming.scheduler.StreamingListener
    -import org.apache.spark.streaming.scheduler.StreamingListenerReceiverStarted
     import org.apache.spark.{SparkConf, SparkFunSuite}
    -import org.apache.spark.util.Utils
    +import org.apache.spark.storage.StorageLevel
    +import org.apache.spark.streaming.{Milliseconds, StreamingContext}
     
     class MQTTStreamSuite extends SparkFunSuite with Eventually with BeforeAndAfter {
     
       private val batchDuration = Milliseconds(500)
       private val master = "local[2]"
       private val framework = this.getClass.getSimpleName
    -  private val freePort = findFreePort()
    -  private val brokerUri = "//localhost:" + freePort
       private val topic = "def"
    -  private val persistenceDir = Utils.createTempDir()
     
       private var ssc: StreamingContext = _
    -  private var broker: BrokerService = _
    -  private var connector: TransportConnector = _
    +  private var MQTTTestUtils: MQTTTestUtils = _
    --- End diff --
    
    Please rename this to not use caps in the first letter ---> `mqttTestUtils`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message