spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <>
Subject [GitHub] spark pull request: [SPARK-8069] [ML] Add multiclass thresholds fo...
Date Tue, 04 Aug 2015 01:47:46 GMT
Github user holdenk commented on a diff in the pull request:
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
    @@ -110,9 +142,9 @@ class LogisticRegression(override val uid: String)
       def setStandardization(value: Boolean): this.type = set(standardization, value)
       setDefault(standardization -> true)
    -  /** @group setParam */
    -  def setThreshold(value: Double): this.type = set(threshold, value)
    -  setDefault(threshold -> 0.5)
    +  override def setThreshold(value: Double): this.type = super.setThreshold(value)
    +  override def getThreshold: Double = super.getThreshold
    --- End diff --
    Is there a particular reason why we overrode getThreshold to just call super.getThreshold
(and if we do maybe we should copy the docs)?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message